winapi - Win32 - passing data to CreateThread in a "safe" way -


i have code base creates threads ad-hoc in few places following pattern:

  1. use operator new create struct contain "the stuff" thread wants work with.
  2. call win32 createthread() api.
  3. in thread proc cast lpvoid object new'ed in step 1.
  4. use object , manually delete it.

this works has couple of issues:

  1. static code analyzers think objected in step 1 can leaked, guess in fact true cases createthread fails.
  2. i'd way make more raii/automatic.
  3. the manual casting can error prone.

i figured std::shared_ptr might solution, e.g in step 1 replace new std::make_shared. seems have other problems:

  1. i don't think same instance of std::shared_ptr can used in other thread?
  2. what if function calls createthread exits before thread proc starts, using dangling pointer?

can suggest more elegant , safe way of doing this? other option can think of have class wraps createthread , has std::shared_ptr member , calls lamba thread proc?


Comments

Post a Comment

Popular posts from this blog

Python Kivy ListView: How to delete selected ListItemButton? -

Image
i'm trying learn kivy building simple todo-list app suggested dusty phillips, author of book "creating apps in kivy". this code far: from kivy.app import app kivy.uix.boxlayout import boxlayout kivy.properties import objectproperty kivy.uix.listview import listitembutton class taskbutton(listitembutton): pass class todoroot(boxlayout): task_input = objectproperty() task_list = objectproperty() def add_task(self): self.task_list.adapter.data.extend([self.task_input.text]) self.task_list._trigger_reset_populate() def del_task(self): pass class todoapp(app): def build(self): return todoroot() if __name__ == '__main__': todoapp().run() and kv file: #: import main todo #: import listadapter kivy.adapters.listadapter.listadapter #: import listitembutton kivy.uix.listview.listitembutton todoroot: <todoroot>: orientation: "vertical" task_input: task_input_view t...
Read more

ruby - How do I merge two hashes into a hash of arrays? -

http://codepad.org/wmyzqlis i'd merge these 2 arrays: a = { :a => 'a', :b => 'b', :d => 'd' } b = { :a => '1', :b => 'b', :c => 'c' } into hash looks this: {:a => ["a", "1"], :b => ["b", "b"], :c => [nil, "c"], :d => ["d", nil] } this doesn't work: p a.merge(b) { |k, v1, v2| [v1, v2] } # {:c=>"c", :a=>["a", "1"], :b=>["b", "b"], :d=>"d"} it's because hash#merge call block duplicate keys. a = { :a => 'a', :b => 'b', :d => 'd' } b = { :a => '1', :b => 'b', :c => 'c' } hash[(a.keys|b.keys).map { |key| [key, [a.fetch(key, nil), b.fetch(key, nil)]] }] # => {:a=>["a", "1"], :b=>["b", "b"], :d=>["d", nil], :c=>...
Read more